Skip to content

Conversation

@Descatles
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

This was referenced Aug 6, 2020
@akning-ms
Copy link
Contributor

  • @leni-msft to review as it is for autorest schema

@Descatles
Copy link
Contributor Author

@Descatles Hi. This PR contains so many files. What's this PR used for? Add @akning-ms as an assignee as well.

Hi, this PR is part of the effort to make sdk automation support azure resource manager schema.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Descatles Descatles marked this pull request as draft August 10, 2020 08:54
@Descatles Descatles force-pushed the OnbroadAutorestSchema branch from af8edf4 to 252aae5 Compare August 13, 2020 02:00
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Descatles Descatles marked this pull request as ready for review August 13, 2020 02:01
@akning-ms akning-ms merged commit d64c8b3 into Azure:master Aug 13, 2020
innosam pushed a commit to innosam/azure-rest-api-specs that referenced this pull request Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants